villebro commented on a change in pull request #14217:
URL: https://github.com/apache/superset/pull/14217#discussion_r616808605
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -78,7 +78,12 @@ export interface FiltersConfigFormProps {
parentFilters: { id: string; title: string }[];
}
-const FILTERS_WITHOUT_COLUMN = ['filter_timegrain', 'filter_timecolumn'];
+// TODO: Need to do with it something
+const FILTERS_WITHOUT_COLUMN = [
+ 'filter_timegrain',
+ 'filter_timecolumn',
+ 'filter_groupby',
+];
Review comment:
Yes, we really need to address this at some point. I suggest once we do
dynamic controls we make sure we can use the same control panel for the filter
config modal and Explore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
