graceguo-supercat commented on pull request #13306: URL: https://github.com/apache/superset/pull/13306#issuecomment-823505721
Unfortunately this PR caused dashboard performance issue for airbnb: <img width="793" alt="Screen Shot 2021-04-20 at 11 03 43 AM" src="https://user-images.githubusercontent.com/27990562/115443621-549c6980-a1c8-11eb-83f6-e8796a2d4610.png";> Please see this chart, which is daily median value of all dashboard metadata load time (in airbnb). After metadata is loaded, dashboard will fetch charts and render charts. You will see that after 4/15 (release date) the dashboard metadata load time is increased a lot, up to now the load time increased about ~30%. In airbnb we have a lot of big dashboard, which have >100 charts from multiple datasets. The original solution, load full dashboard data in one API and **cache** the dashboard request, was one of proven way which improved dashboard load performance. But this good practice seems will not be carried over. Given the impact to our performance metric, airbnb is reverted this PR from our own production environment. I hope open source community and Preset team could re-consider this solution. By now we would suggest: - add feature flag for this SPA solution, so that airbnb can escape from this change - add cache for all the new API, to reduce the server-side dashboards/datasets/charts request processing time. @ktmud @pkdotson @junlincc @zuzana-vej -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/115443621-549c6980-a1c8-11eb-83f6-e8796a2d4610.png"](https://user-images.githubusercontent.com/27990562/115443621-549c6980-a1c8-11eb-83f6-e8796a2d4610.png"){kind=link}