graceguo-supercat commented on pull request #13306: URL: https://github.com/apache/superset/pull/13306#issuecomment-823741988
<img width="941" alt="Screen Shot 2021-04-20 at 7 51 51 PM" src="https://user-images.githubusercontent.com/27990562/115489967-fbf1be80-a211-11eb-9e77-07b4f5683354.png";> Hey @junlincc and @suddjian We have 1 more data point: once we reverted this PR (this PR and #18184 are the only change), the perf goes back to normal. We didn't run full 24 hours since the revert was happened after UTC 0:00. Can this chart enough to show the perf impact? As you see, more recent PRs are based on this change, it will be very hard for us to sync weekly with master branch and keep this PR out. Could you help to make some simple fix so that we can move forward, like @ktmud suggested above? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/115489967-fbf1be80-a211-11eb-9e77-07b4f5683354.png"](https://user-images.githubusercontent.com/27990562/115489967-fbf1be80-a211-11eb-9e77-07b4f5683354.png"){kind=link}