[GitHub] [superset] lyndsiWilliams opened a new pull request #14293: refactor: Move fields from Extra section II

[GitBox]

lyndsiWilliams opened a new pull request #14293:
URL: https://github.com/apache/superset/pull/14293


   ### SUMMARY
   Move the existing fields from the "Extra" section to the following sections. 
This also includes moving them to be fields instead of one json string.
   
   -  SQL Lab
        - allows_virtual_table_explore
   
   - Performance
        - Metadata Cache Timeout with Schema and Table options 
(metadata_cache_timeout)
   
   - Security
        - Schema select for uploading data (schemas_allowed_for_csv_upload)
        - Impersonate logged in user
        - Allow data upload
   
   - Other
        - engine_params and metadata params (in a json field)
        - version
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   - BEFORE
   
        **SQL Lab**
        <img width="500" alt="sqllab-before" 
src="https://user-images.githubusercontent.com/55605634/115647165-f6b37300-a2e8-11eb-9c7c-49b8835d3bce.png";>
   
        **Performance**
        <img width="500" alt="performance-before" 
src="https://user-images.githubusercontent.com/55605634/115647195-ffa44480-a2e8-11eb-89fd-2ab0ca2083b9.png";>
   
        **Security**
        <img width="500" alt="security-before" 
src="https://user-images.githubusercontent.com/55605634/115647201-029f3500-a2e9-11eb-82c5-9bbfd3fee560.png";>
   
        **Other**
        <img width="500" alt="other-before" 
src="https://user-images.githubusercontent.com/55605634/115647217-06cb5280-a2e9-11eb-9892-ec3cfd9e9914.png";>
   
   
   - AFTER
   
        **SQL Lab**
        <img width="500" alt="sqllab-after" 
src="https://user-images.githubusercontent.com/55605634/115647267-16e33200-a2e9-11eb-8f2d-bec9f7287b1a.png";>
   
        **Performance**
        <img width="500" alt="performance-after" 
src="https://user-images.githubusercontent.com/55605634/115647277-19458c00-a2e9-11eb-9ce9-5aa30210e3c6.png";>
   
        **Security**
        <img width="500" alt="security-after-1" 
src="https://user-images.githubusercontent.com/55605634/115647288-1d71a980-a2e9-11eb-95da-b34ecbf75220.png";>
        <img width="500" alt="security-after-2" 
src="https://user-images.githubusercontent.com/55605634/115647302-21053080-a2e9-11eb-8ece-f622bb6b2c8b.png";>
   
        **Other**
        -- COMING SOON --
   
   
   ### TEST PLAN
   
   1. From the "Databases" page, open the database modal by clicking either the 
"+ DATABASE" button or the "Edit" action button on any listed database.
   2. Observe the described changes on the following tabs: SQL Lab, 
Performance, Security, Other
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: [Clubhouse 
Ticket](https://app.clubhouse.io/preset/story/6947/step-3-move-fields-from-extra-section)
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org