eschutho commented on a change in pull request #14293:
URL: https://github.com/apache/superset/pull/14293#discussion_r621598230
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -115,6 +117,14 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
...db,
};
+ // Parse 'extra' field
+ const extraParsed = JSON.parse(update?.extra || defaultExtra);
Review comment:
I think this makes more sense being db?.extra || defaultExtra, because
that's closer to the source and matches the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
