graceguo-supercat edited a comment on issue #14307: URL: https://github.com/apache/superset/issues/14307#issuecomment-825802620
Hi @villebro Thank you for the reply. So this option should match with old filter_box `Required` option. "Enable empty filter" means _**is required**_ (not clearable). 1. `enable empty filter` is very misleading message. It should just say `Required` as before. 2. When user click APPLY button but did not fill a required filter, right now it just shows **No Results**, user has no idea about some filter is wrong, or actually no results. Could we **highlight / show error message** on the required filter field? It will clearly tell user how to use this filter. cc @junlincc this is a very misleading bug, please prioritize it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
