villebro commented on issue #14307:
URL: https://github.com/apache/superset/issues/14307#issuecomment-825839702


   I believe the "Enable empty filter" and "Required" options try to address 
the same thing. The main difference I believe is as follows:
   - When a dashboard with a required field is loaded, it initially loads with 
no filters applied. In the following example I have a filter box where the 
user_id field is set to Required, but the dashboard loads up with no filters 
applied:
   
![image](https://user-images.githubusercontent.com/33317356/115913695-99026080-a479-11eb-9c9a-8ff3ed8aa9a7.png)
   - This may be a bug, but I was not able to get "Required" to work - in the 
screenshot below, `user_id` is required, but `event_id` is not, and I was still 
able to apply the filter on `event_id` despite `user_id` being unset:
   
![image](https://user-images.githubusercontent.com/33317356/115913910-e67ecd80-a479-11eb-8b91-8c9bd49281bd.png)
   
![image](https://user-images.githubusercontent.com/33317356/115914005-0615f600-a47a-11eb-961d-c07ec7053e9a.png)
   
   I'm happy to work on adding the intended functionality for the "Required" 
option, and if we can consolidate it somehow with the "Enable empty filter" 
option then that would be optimal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to