villebro opened a new pull request #14346:
URL: https://github.com/apache/superset/pull/14346


   ### SUMMARY
   Add support for sort metric to native select filter. This is a requirement 
to establish feature parity with Filter Box.
   
   ### SCREENSHOTS
   An optional field appears on the filter config modal for the select filter:
   
![image](https://user-images.githubusercontent.com/33317356/116047952-51e4bd00-a67d-11eb-974d-d14f89376f03.png)
   When selected, the column values are sorted by the selected metric (in this 
case in descending order)
   
![image](https://user-images.githubusercontent.com/33317356/116048001-632dc980-a67d-11eb-92f4-38f27527d4b5.png)
   
   ### TEST PLAN
   Local testing + CI
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to