kgabryje commented on a change in pull request #14346:
URL: https://github.com/apache/superset/pull/14346#discussion_r620169479
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -115,16 +122,33 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
const hasColumn =
hasDataset && !FILTERS_WITHOUT_COLUMN.includes(formFilter?.filterType);
+ const datasetId = formFilter?.dataset?.value;
+
+ useEffect(() => {
+ if (datasetId) {
Review comment:
If https://github.com/apache/superset/pull/14313 is merged first, that
won't be necessary - metrics can be accessed in `formFilter.dataset?.metrics`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
