Steejay commented on pull request #14298: URL: https://github.com/apache/superset/pull/14298#issuecomment-827678821
@zuzana-vej I dont think all limit indicators should be in an alert state. we want to avoid adding disruptive messaging every time a user runs a query. there were 2 states we looked at when designing this message. First was a general limit indicator that is supposed to give non disruptive feedback to the user that x amount of rows were returned based on a limit constraint they applied in the UI somewhere (sql or dropdown). The second state is when a limit was applied based on a limit constraint configured on the server side (something a non admin could not see in the UI). For this state an alert was used to bring attention to the user that if they are seeing a row llimit that isnt shown in the UI its because of a configuration on the server side. hence the alert state (and improved copy you suggested in a previous issue). cc @AAfghahi @yousoph -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
