eschutho commented on pull request #14293: URL: https://github.com/apache/superset/pull/14293#issuecomment-827944899
This looks good.. I would suggest one small thing. If you were to think of `db` as you current model.. then I would keep the schema of that object always matching what you need on the front end. Therefore, I would keep metadata_cache_timeout and schemas_allowed_for_csv_upload as properties on that model. Then do the transforms on fetch and save.. this way you don't need to also store those fields in state. I would also suggest using `useReducer` instead of `useState` for db.. let's talk more! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
