mayurnewase opened a new pull request #14393:
URL: https://github.com/apache/superset/pull/14393


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Add a name to the dataset instead of using table name.
   Helps distinguish if multiple datasets have the same table name, described 
in #14246 
   Will add test and tiny migration if this is accepted.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   For before shots check above issue linked.
   
   After
   
![image](https://user-images.githubusercontent.com/12967587/116422182-1bfe2f00-a85d-11eb-9b9c-2f71e2639362.png)
   
   
![image](https://user-images.githubusercontent.com/12967587/116422057-ff61f700-a85c-11eb-9b6e-54560f0fcde5.png)
   
   ![Screenshot from 2021-04-28 
20-06-36](https://user-images.githubusercontent.com/12967587/116422414-59fb5300-a85d-11eb-86a3-d87b2eb1920a.png)
   
   
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Test adding dataset
   Test editing dataset
   Test exploring chart on dataset
   Test migration
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x ] Has associated issue:
   - [ x] Changes UI
   - [ x] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ x] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to