rusackas commented on a change in pull request #14364:
URL: https://github.com/apache/superset/pull/14364#discussion_r622746261
##########
File path: superset-frontend/src/profile/components/App.tsx
##########
@@ -32,6 +31,14 @@ interface AppProps {
user: UserWithPermissionsAndRoles;
}
+const StyledPanel = styled.div`
+ padding: 10px;
+ .ant-tabs-content-holder {
Review comment:
If the above line of padding comes out, then I wouldn't use the styled
component as implemented here. Rather than making a styled component which
wraps all the `Tabs.TabPane` components, and affecting them with this
`.ant-tabs-content-holder` class selector, I would make a `StyledTabPane` with
just the two CSS properties, and use that in the JSX markup directly instead of
`TabPane`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
