villebro commented on pull request #14443: URL: https://github.com/apache/superset/pull/14443#issuecomment-831037620
Reviewing/testing #14408 first, but one problem with this approach is that it will cause two renders of charts - first with the full width of the dashboard without the filter tab, and next with the filter tab. To address this I would recommend making the filter tab visible initially, but potentially introduce the loading spinner instead of the tab contents to highlight that filters are still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
