villebro commented on a change in pull request #14443:
URL: https://github.com/apache/superset/pull/14443#discussion_r625742618
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
##########
@@ -238,7 +243,9 @@ const FilterBar: React.FC<FiltersBarProps> = ({
dataMaskSelected={dataMaskSelected}
dataMaskApplied={dataMaskApplied}
/>
- {isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS_SET) ? (
+ {!isInitialized ? (
+ <Loading />
+ ) : isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS_SET) ? (
Review comment:
I think this causes an unnecessary visual artefact - I think it's ok to
keep this as-is, i.e. showing the filters in spinning state until they've fully
resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
