eschutho commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r625926870
##########
File path: superset-frontend/src/SqlLab/components/QueryHistory.tsx
##########
@@ -31,21 +31,23 @@ interface QueryHistoryProps {
const QueryHistory = ({ queries, actions, displayLimit }: QueryHistoryProps) =>
queries.length > 0 ? (
- <QueryTable
- columns={[
- 'state',
- 'started',
- 'duration',
- 'progress',
- 'rows',
- 'sql',
- 'output',
- 'actions',
- ]}
- queries={queries}
- actions={actions}
- displayLimit={displayLimit}
- />
+ <div className="scrollable">
Review comment:
I'd suggest what Evan was demoing the other day and use emotion's css
property here instead:
https://codesandbox.io/s/emotion-playground-forked-7z07l?file=/src/index.js
That way you can reuse a scrollable style instead of a class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
