eschutho commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r625930361
##########
File path: superset-frontend/src/SqlLab/components/QueryTable.jsx
##########
@@ -100,43 +108,43 @@ const QueryTable = props => {
</div>
);
q.user = (
- <Button
+ <StyledButton
buttonSize="small"
buttonStyle="link"
onClick={() => props.onUserClicked(q.userId)}
>
{q.user}
- </Button>
+ </StyledButton>
);
q.db = (
- <Button
+ <StyledButton
buttonSize="small"
buttonStyle="link"
onClick={() => props.onDbClicked(q.dbId)}
>
{q.db}
- </Button>
+ </StyledButton>
);
q.started = moment(q.startDttm).format('HH:mm:ss');
q.querylink = (
- <Button
+ <StyledButton
buttonSize="small"
buttonStyle="link"
onClick={() => openQuery(q.queryId)}
>
<i className="fa fa-external-link m-r-3" />
{t('Edit')}
- </Button>
+ </StyledButton>
Review comment:
it feels a little weird to make all of these buttons static. Can we put
them in a wrapper that is static instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
