pkdotson commented on pull request #14379:
URL: https://github.com/apache/superset/pull/14379#issuecomment-832446325


   I noticed some slight differences from production and the testing env for 
save chart modal. The label texts are darker in your pr while in production the 
text is lighter gray (kinda hard to see from my poor resolution screenshot, 
copied the css): 
   ![Screen Shot 2021-05-04 at 11 20 59 
PM](https://user-images.githubusercontent.com/17326228/117103545-64bb5980-ad2f-11eb-82a4-39e7fa8827d0.png)
   ![Screen Shot 2021-05-04 at 11 23 23 
PM](https://user-images.githubusercontent.com/17326228/117103748-bd8af200-ad2f-11eb-8384-3bd18cad65fc.png)
   ![Screen Shot 2021-05-04 at 11 23 42 
PM](https://user-images.githubusercontent.com/17326228/117103763-c54a9680-ad2f-11eb-85c1-ba97dc6acf75.png)
   
   
   ![Screen Shot 2021-05-04 at 11 21 29 
PM](https://user-images.githubusercontent.com/17326228/117103590-769cfc80-ad2f-11eb-8b3a-f7d056e59224.png)
   
   Also the highlighting is a little different in the form. Might want to check 
with desgin @mihir174 if the new highlight works, just to be consistent 
throughout the app.
   ![Screen Shot 2021-05-04 at 11 29 14 
PM](https://user-images.githubusercontent.com/17326228/117104177-8b2dc480-ad30-11eb-9ed2-05d0cd069b40.png)
   ![Screen Shot 2021-05-04 at 11 29 25 
PM](https://user-images.githubusercontent.com/17326228/117104191-9123a580-ad30-11eb-9ece-6aa7ea1ae9b8.png)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to