michael-s-molina commented on pull request #14379: URL: https://github.com/apache/superset/pull/14379#issuecomment-832629174
> I noticed some slight differences from production and the testing env for save chart modal. The label texts are darker in your pr while in production the text is lighter gray (kinda hard to see from my poor resolution screenshot, copied the css): >  >  >  > >  > > Also the highlighting is a little different in the form. Might want to check with desgin @mihir174 if the new highlight works, just to be consistent throughout the app. >  >  @pkdotson Thanks for reviewing. Those changes were intentional. - The color of label texts in production doesn't exist currently in our theme. I replaced it with the theme color `grayscale.base`. - The "Chart Name" change was to use our `Input` component. There's another PR that changes the `Input` theme to be the same as the AntD default theme and then the color will be the same as production. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
