simcha90 commented on a change in pull request #14488:
URL: https://github.com/apache/superset/pull/14488#discussion_r626592332
##########
File path: superset-frontend/src/chart/ChartRenderer.jsx
##########
@@ -228,6 +231,7 @@ class ChartRenderer extends React.Component {
formData={formData}
ownState={ownState}
filterState={filterState}
+ extraFormData={extraFormData}
Review comment:
I'm not sure that we need to pass `extraFormData` to `SuperChart`
because this data should be used only in `buildQuery` function and `SuperChart`
should use `filterState` for it needs @villebro thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
