villebro commented on a change in pull request #14488:
URL: https://github.com/apache/superset/pull/14488#discussion_r626626507
##########
File path: superset-frontend/src/chart/ChartRenderer.jsx
##########
@@ -228,6 +231,7 @@ class ChartRenderer extends React.Component {
formData={formData}
ownState={ownState}
filterState={filterState}
+ extraFormData={extraFormData}
Review comment:
`interactive_drilldown` should be merged from `ExtraFormData` to
`QueryFormData` when calling the `setDataMask` hook, and should really only be
used when broadcasting to another chart. When a chart wants to broadcast data
to itself only you should use `ownState`. Is this what you want to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
