AAfghahi commented on a change in pull request #14451:
URL: https://github.com/apache/superset/pull/14451#discussion_r628261275



##########
File path: superset/databases/schemas.py
##########
@@ -327,6 +329,7 @@ class Meta:  # pylint: disable=too-few-public-methods
         description=cache_timeout_description, allow_none=True
     )
     expose_in_sqllab = fields.Boolean(description=expose_in_sqllab_description)
+    configuration_method = EnumField(ConfigurationMethod, by_value=True)

Review comment:
       `  # configuration_method is used on the frontend to inform the backend 
whether to explode parameters or to provide only a sqlalchemy_uri
   
   configuration_method = EnumField(ConfigurationMethod, by_value=True)`
   
   Does this look ok?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to