eschutho commented on a change in pull request #14451:
URL: https://github.com/apache/superset/pull/14451#discussion_r628562275
##########
File path: superset/databases/schemas.py
##########
@@ -327,6 +329,7 @@ class Meta: # pylint: disable=too-few-public-methods
description=cache_timeout_description, allow_none=True
)
expose_in_sqllab = fields.Boolean(description=expose_in_sqllab_description)
+ configuration_method = EnumField(ConfigurationMethod, by_value=True)
Review comment:
We have two choices here.. let's discuss. When saving the database, the
return is a sqlalchemy_uri, regardless of how the database was created. The new
form is a two step form, so you basically create and then update. My current
plan (pr isn't up yet, but I can paste it here for reference) is to not provide
the configuration_method in the put. There are no plans as of now to allow
people to switch from one to the other once they have created the database. But
@yousoph and @steejay and I have been talking about this, so it could change.
The other option is to return the parameters and the configuration_method value
with the save db response, which would be a more flexible solution, but might
take more time to implement, and as it looks now we don't need it, so it could
wait for a v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
