[GitHub] [superset] eschutho opened a new pull request #14583: feat: save database with new dynamic form

[GitBox]

eschutho opened a new pull request #14583:
URL: https://github.com/apache/superset/pull/14583


   ### SUMMARY
   This PR loads the form dynamically (based on 
https://github.com/apache/superset/pull/14456) and saves the database with the 
new form. The dynamic form is hidden behind a local flag, so it does not 
currently show up in the UI. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   existing visualization is mostly the same with a few small tweaks
   <img width="542" alt="Screenshot_5_11_21__6_41_PM" 
src="https://user-images.githubusercontent.com/5186919/117906150-3a1a5500-b289-11eb-9c40-5f5cc8a422af.png";>
   The tabs now reach across the fill width of the modal
   
   <img width="565" alt="Screenshot_5_11_21__6_41_PM" 
src="https://user-images.githubusercontent.com/5186919/117906238-62a24f00-b289-11eb-9bc0-055594da5e48.png";>
   Display name used to say "Name your dataset" as the placeholder. It's 
changed to "Name your database"
   
   with button enabled (same as before)
   <img width="547" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/117906196-50c0ac00-b289-11eb-82bc-e7a4bff3bcca.png";>
   
   
   
   ### TEST PLAN
   new unit tests.. because some values are still hard coded, we can't test the 
new flow too much yet.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org