eschutho commented on a change in pull request #14583:
URL: https://github.com/apache/superset/pull/14583#discussion_r631489369
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -252,10 +309,32 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
setTabKey(key);
};
+ const dbModel: DatabaseForm =
+ availableDbs?.databases?.find(
+ (available: { engine: string | undefined }) =>
+ available.engine === db?.parameters?.engine,
+ ) || {};
+
+ const disableSave =
+ !hasConnectedDb &&
+ (useSqlAlchemyForm
+ ? !(db?.database_name?.trim() && db?.sqlalchemy_uri)
+ : // disable the button if there is no dbModel.parameters or if
+ // any required fields are falsy
+ !dbModel?.parameters ||
+ !!dbModel.parameters.required.filter(field =>
+ FALSY_FORM_VALUES.includes(db?.parameters?.[field]),
+ ).length);
+
return isEditMode || useSqlAlchemyForm ? (
- <StyledModal
+ <Modal
+ css={(theme: SupersetTheme) => [
+ antDTabsStyles,
+ antDModalStyles(theme),
+ antDModalNoPaddingStyles,
+ formHelperStyles(theme),
Review comment:
in a future version, I'd like to pass a prop to the modal for theming,
or use something like Modal.noPadding to make the changes more global. Inspired
by @rusackas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
