eschutho commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r631451615
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -501,22 +529,79 @@ export default class ResultSet extends
React.PureComponent<
return <div />;
}
+ onAlertClose = () => {
+ this.setState({ alertIsOpen: false });
+ };
+
renderRowsReturned() {
- const { results, rows, queryLimit } = this.props.query;
- const limitReached = results?.displayLimitReached;
+ const { results, rows, queryLimit, limitingFactor } = this.props.query;
+ let limitMessage;
+ const isAdmin = this.props.user?.roles.hasOwnProperty('Admin');
Review comment:
it's not that `hasOwnProperty` doesn't work, it's just that it was
mainly used to make sure that the object isn't inheriting the property from
something up the prototype chain, and so I was trying to think about why that
was an issue. I think the other methods are more common nowadays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
