eschutho commented on a change in pull request #14381:
URL: https://github.com/apache/superset/pull/14381#discussion_r631453139
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -56,6 +55,21 @@ const EXPLORE_CHART_DEFAULT = {
viz_type: 'table',
};
+enum LIMITING_FACTOR {
+ QUERY = 'QUERY',
+ QUERY_AND_DROPDOWN = 'QUERY_AND_DROPDOWN',
+ DROPDOWN = 'DROPDOWN',
+ NOT_LIMITED = 'NOT_LIMITED',
+}
+
+function limitReached(displayLimitReached: boolean) {
+ return displayLimitReached;
+}
+
+function defaultDropdown(queryLimit: number, limitingFactor: string) {
Review comment:
can we make the name more indicative of what this function does? Does it
return a boolean, then maybe `shouldShowDefaultDropdown`? or `shouldUse...`
whatever fits better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
