suddjian commented on a change in pull request #14580:
URL: https://github.com/apache/superset/pull/14580#discussion_r632734882
##########
File path: superset-frontend/src/common/components/index.tsx
##########
@@ -163,17 +171,24 @@ export const StyledSubMenu = styled(AntdMenu.SubMenu)`
background-color: ${({ theme }) => theme.colors.primary.base};
}
}
+ .ant-menu-submenu-arrow {
+ top: 67%;
+ }
& > .ant-menu-submenu-title {
padding: 0 ${({ theme }) => theme.gridUnit * 6}px 0
${({ theme }) => theme.gridUnit * 3}px !important;
svg {
position: absolute;
- top: ${({ theme }) => theme.gridUnit * 4}px;
+ top: ${({ theme }) => theme.gridUnit * 4 + 7}px;
Review comment:
This depends on what relationship we want the svg to have to the grid
unit. When pixel amounts are hardcoded, it should be to format the thing being
positioned so that it can look right in any grid. We could also do
`theme.gridUnit * 6 - 1`, for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
