geido commented on a change in pull request #14580:
URL: https://github.com/apache/superset/pull/14580#discussion_r633542749
##########
File path: superset-frontend/src/components/Menu/MenuRight.tsx
##########
@@ -98,7 +98,7 @@ const RightMenu = ({
))}
</SubMenu>
)}
- <SubMenu title="Settings" icon={<Icon name="triangle-down" />}>
+ <SubMenu title="Settings" style={{margin: 0}}icon={<Icon
name="triangle-down" />}>
Review comment:
Same as my other comment about the inline style
##########
File path: superset-frontend/src/components/Menu/MenuRight.tsx
##########
@@ -81,7 +81,7 @@ const RightMenu = ({
<SubMenu
data-test="new-dropdown"
title={
- <StyledI data-test="new-dropdown-icon" className="fa fa-plus" />
+ <StyledI data-test="new-dropdown-icon" style={{margin:0}}
className="fa fa-plus" />
Review comment:
Can remove the inline style and move it to the styled component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
