hughhhh commented on a change in pull request #14583:
URL: https://github.com/apache/superset/pull/14583#discussion_r633674500
##########
File path: superset-frontend/src/views/CRUD/data/database/types.ts
##########
@@ -52,3 +54,49 @@ export type DatabaseObject = {
allow_csv_upload?: boolean;
extra?: string;
};
+
+export type DatabaseForm = {
+ engine: string;
+ name: string;
+ parameters: {
+ properties: {
+ database: {
+ description: string;
+ type: string;
+ };
+ host: {
+ description: string;
+ type: string;
+ };
+ password: {
+ description: string;
+ nullable: boolean;
+ type: string;
+ };
+ port: {
+ description: string;
+ format: string;
+ type: string;
+ };
+ query: {
+ additionalProperties: {};
+ description: string;
+ type: string;
+ };
+ username: {
+ description: string;
+ nullable: boolean;
+ type: string;
+ };
+ };
+ required: string[];
+ type: string;
+ };
+ preferred: boolean;
+ sqlalchemy_uri_placeholder: string;
+};
+
+export enum CONFIGURATION_METHOD {
Review comment:
we need to figure out how to centralize enums between the FE and BE, can
we add a comment here to reference the python enums
https://github.com/apache/superset/blob/4f5c5372509476f4f4d7299872b54093b759c090/superset/models/core.py#L102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
