mssun commented on a change in pull request #573:
URL: https://github.com/apache/incubator-teaclave/pull/573#discussion_r743868849
##########
File path: executor/src/wamr.rs
##########
@@ -115,10 +115,10 @@ impl TeaclaveExecutor for WAMicroRuntime {
set_thread_context(Context::new(runtime))?;
- unsafe { wasm_runtime_init() };
+ let ret = unsafe { wasm_runtime_init() };
+ assert!((ret as bool) != false);
Review comment:
The type of `ret` is `bool`, why do you cast it again?
##########
File path: executor/src/wamr.rs
##########
@@ -115,10 +115,10 @@ impl TeaclaveExecutor for WAMicroRuntime {
set_thread_context(Context::new(runtime))?;
- unsafe { wasm_runtime_init() };
+ let ret = unsafe { wasm_runtime_init() };
+ assert!((ret as bool) != false);
Review comment:
The type of `ret` is `bool`, why do you cast it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For additional commands, e-mail: notifications-h...@teaclave.apache.org
