bigdata-memory commented on a change in pull request #573:
URL: https://github.com/apache/incubator-teaclave/pull/573#discussion_r749599798
##########
File path: executor/src/wamr.rs
##########
@@ -115,10 +115,10 @@ impl TeaclaveExecutor for WAMicroRuntime {
set_thread_context(Context::new(runtime))?;
- unsafe { wasm_runtime_init() };
+ let ret = unsafe { wasm_runtime_init() };
+ assert!((ret as bool) != false);
Review comment:
@qinkunbao if possible, as @mssun mentioned, I suggest that the current
code could be further slightly improved as follows.
```
let ret = unsafe { wasm_runtime_init() };
assert!(ret != false);
```
Please refer to
https://github.com/apache/incubator-teaclave/blob/0ad267f2eabba17fca6fb01ec4c7dc2786d4813f/executor/src/wamr.rs#L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@teaclave.apache.org
For additional commands, e-mail: notifications-h...@teaclave.apache.org
