kunwp1 commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2638285786
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/model/ReadonlyVirtualDocument.scala:
##########
@@ -54,7 +54,7 @@ trait ReadonlyVirtualDocument[T] {
* @param until the ending index (exclusive)
* @return an iterator that returns data items of type T
Review Comment:
add a comment to describe the parameter
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
@@ -66,6 +66,9 @@ export class ResultTableFrameComponent implements OnInit,
OnChanges {
currentPageIndex: number = 1;
totalNumTuples: number = 0;
pageSize = 5;
+ currentColumnOffset = 0;
+ columnLimit = 25;
Review Comment:
Can you add a comment on why you decided to use "25" as column limit? I also
whether it's better to make it a configurable parameter in `.conf` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
