aglinxinyuan commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2651933231
##########
frontend/src/app/workspace/component/result-panel/result-panel.component.ts:
##########
@@ -52,7 +52,7 @@ import { CompilationState } from
"../../types/workflow-compiling.interface";
import { WorkflowFatalError } from "../../types/workflow-websocket.interface";
export const DEFAULT_WIDTH = 800;
-export const DEFAULT_HEIGHT = 300;
+export const DEFAULT_HEIGHT = 500;
Review Comment:
Can we keep the height at 300? Taking space from another component doesn’t
seem like a good way to address the issue.
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html:
##########
@@ -25,6 +25,39 @@ <h4>Empty result set</h4>
<div
[hidden]="!currentColumns"
class="result-table">
+ <div
+ class="column-search"
+ style="margin-bottom: 8px; display: flex; justify-content: flex-end">
+ <input
+ nz-input
+ placeholder="Search Columns"
+ (input)="onColumnSearch($event)"
+ style="width: 200px" />
+ </div>
+ <div
+ class="column-navigation"
+ style="margin-bottom: 8px; display: flex; justify-content: flex-end; gap:
8px">
+ <button
Review Comment:
Can we hide those two buttons when there are just a few columns? We don't
need those when there are just three columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
