carloea2 commented on code in PR #4146:
URL: https://github.com/apache/texera/pull/4146#discussion_r2669328998
##########
file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala:
##########
@@ -715,7 +727,55 @@ class DatasetResource {
if (session == null)
throw new NotFoundException("Upload session not found. Call type=init
first.")
- val expectedParts = session.getNumPartsRequested
+ val expectedParts: Int = session.getNumPartsRequested
+ val fileSizeBytesValue: Long = session.getFileSizeBytes
+ val partSizeBytesValue: Long = session.getPartSizeBytes
+
+ if (fileSizeBytesValue <= 0L) {
Review Comment:
1) Since this is the endpoint for uploading a part, no record is created in
this endpoint at this moment, so no record should be deleted here in case of
errors, the current logic relies that all the parts rows are created on init
phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
