aicam commented on code in PR #4146: URL: https://github.com/apache/texera/pull/4146#discussion_r2683445473
########## file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala: ########## Review Comment: - I don't understand whats difference between `validateAndNormalizeFilePathOrThrow` and catching error of `parsePhysicalAddress`, even if you want to check twice, why checking with two different methods? - If the record comes from database, I believe you don't need to check it twice, because if writer process do it correctly, checking by reader process is redundant, if its a request parameter (something that user can manipulate), then I agree that it should be checked both at writing and reading time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
