Ma77Ball commented on code in PR #36: URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3120609655
########## content/en/docs/contribution-guidelines/_index.md: ########## @@ -39,6 +39,8 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo ### 3. Create and Submit a Pull Request - Develop in a new branch of your fork. + - If your PR modifies the SQL schema, be sure to modify `sql/changelog.xml`. + - Also omit `\c texera_db` from the top of your SQL update file as Liquibase cannot parse this line. Review Comment: ```suggestion > **Modifying the SQL schema?** > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line. ``` ########## content/en/docs/contribution-guidelines/_index.md: ########## @@ -39,6 +39,8 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo ### 3. Create and Submit a Pull Request - Develop in a new branch of your fork. + - If your PR modifies the SQL schema, be sure to modify `sql/changelog.xml`. + - Also omit `\c texera_db` from the top of your SQL update file as Liquibase cannot parse this line. - When ready, submit a PR to the main Texera repository. - **Allow edits from maintainers** to let committers make small fixes if needed. Review Comment: This appears to be a warning, and I think it should be moved to this line, in block quotes (as suggested above). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
