kunwp1 commented on code in PR #4347:
URL: https://github.com/apache/texera/pull/4347#discussion_r3150093460
##########
amber/src/main/scala/org/apache/texera/web/service/ResultExportService.scala:
##########
@@ -113,6 +121,18 @@ class ResultExportService(workflowIdentity:
WorkflowIdentity, computingUnitId: I
}
}
+ // After all operators are uploaded, commit each dataset as a new version
+ if (successMessages.nonEmpty) {
+ request.datasetIds.foreach { did =>
+ try {
+ commitDatasetVersion(user, did, s"Export from workflow
${request.workflowName}")
Review Comment:
What's the reason not to commit inside `exportSingleOperatorToDataset`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
