kunwp1 commented on code in PR #4347:
URL: https://github.com/apache/texera/pull/4347#discussion_r3150100308


##########
amber/src/main/scala/org/apache/texera/web/service/ResultExportService.scala:
##########
@@ -571,6 +591,50 @@ class ResultExportService(workflowIdentity: 
WorkflowIdentity, computingUnitId: I
     }
   }
 
+  /**
+    * Commit staged files in a dataset as a new version by calling the file 
service.
+    */
+  private def commitDatasetVersion(

Review Comment:
   It has too many shared codes with `saveToDatasets`. Better to refactor the 
code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to