aglinxinyuan opened a new pull request, #4662:
URL: https://github.com/apache/texera/pull/4662
### What changes were proposed in this PR?
Delete the root `Dockerfile`. It is dead code that has been broken since the
`core/` reorganization in late 2025 and is referenced by nothing in the build
system.
**Why it is broken on its own terms.** The file still contains:
- `COPY core/gui/package.json core/gui/yarn.lock ./` and `COPY core/gui .` —
`core/gui/` was relocated to `frontend/` in #3851 (`chore: relocate core/gui to
frontend`).
- `COPY core/ .` — `core/` was renamed to `common/` in #3882 (`chore: rename
core to common`).
- `RUN pip3 install -r requirements.txt` and `RUN pip3 install -r
operator-requirements.txt` — those files now live under `amber/`.
- `FROM node:18-alpine` — the active frontend builder is `node:24-bookworm`
in `bin/texera-web-application.dockerfile` (post #4658).
The last touch was #3877 (`chore: rename core/scripts to bin`, Oct 2025),
which only fixed one path inside this file and left the rest pointing at
directories that no longer exist. `docker build .` against this file fails
immediately — there is nothing to copy from `core/gui/`.
**Why nothing uses it.**
- `.github/workflows/build-and-push-images.yml` builds images by globbing
`bin/*.dockerfile` only.
- `bin/build-images.sh` and `bin/merge-image-tags.sh` likewise iterate
`*.dockerfile` from `bin/`.
- `bin/README.md` documents `bin/*.dockerfile` as the supported pattern
(e.g. `docker build -f bin/texera-web-application.dockerfile -t ... .`).
- The two `docker-compose.yml` files (`bin/single-node/`, `sql/`) consume
pre-built images and do not declare `build:` for the root `Dockerfile`.
`.dockerignore` is intentionally kept — it still applies as a build-context
filter for the active `bin/*.dockerfile` builds run from the project root.
### Any related issues, documentation, discussions?
Closes #4661.
### How was this PR tested?
No automated tests apply; this is a pure deletion of an unreferenced file.
Verified manually that no remaining file references the root `Dockerfile`:
```bash
grep -rIn -E '(^|[^.a-zA-Z/])\./Dockerfile|-f Dockerfile' \
--exclude-dir=node_modules --exclude-dir=.git . | wc -l # → 0
```
The active image-build paths still resolve (`bin/*.dockerfile` enumerated by
both the local `bin/build-images.sh` and the `build-and-push-images.yml` matrix
builder).
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
