mengw15 opened a new pull request, #5125:
URL: https://github.com/apache/texera/pull/5125

   ### What changes were proposed in this PR?
   
   The user-workflow-list eye-icon opens `HubWorkflowDetailComponent` inside an 
`nz-modal` whose width is set to 60% of the viewport via `nzStyle: { width: 
"60%" }`. On narrow viewports (~800px) this yields a ~480px modal, and 
`HubWorkflowDetailComponent`'s desktop-oriented header layout breaks:
   
   - The `<h1>Workflow Detail Page</h1>` wraps to three lines (`Workflow` / 
`Detail` / `Page`).
   - The four panel buttons (👁 view, 👍 like, 👤 clones, Clone) overflow.
   - The `Clone` button gets clipped off the right edge of the modal.
   
   This PR swaps the outlier `nzStyle: { width: "60%" }` for the 
codebase-standard `nzWidth: "900px"` — matching the workspace "Edit Workflow 
Description" modal at 
[`menu.component.ts:668`](https://github.com/apache/texera/blob/main/frontend/src/app/workspace/component/menu/menu.component.ts#L668)
 as well as the three other modals in this same file (lines 222, 236, 284), all 
of which use `nzWidth: "<N>px"` strings. 900px comfortably fits the header row.
   
   The internal layout of `HubWorkflowDetailComponent` itself is not changed; 
making it truly responsive is a larger follow-up out of scope here.
   
   ### Any related issues, documentation, discussions?
   
   Closes #4877.
   
   ### How was this PR tested?
   
   CSS-only modal width adjustment. The fix is mechanical (one literal swap), 
so no automated test added — a unit test would only assert that the 
modal-creation call receives the new literal, which is a tautology of the diff. 
Verified locally by running the frontend dev server, navigating to the user 
workflow panel, and clicking the eye icon: the modal now opens at 900px with 
the title on one line, all four buttons visible, and no horizontal overflow.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to