mengw15 commented on code in PR #5125:
URL: https://github.com/apache/texera/pull/5125#discussion_r3256443550
##########
frontend/src/app/dashboard/component/user/list-item/list-item.component.ts:
##########
@@ -406,7 +406,7 @@ export class ListItemComponent implements OnChanges {
wid: wid ?? 0,
},
nzFooter: null,
- nzStyle: { width: "60%" },
Review Comment:
Done in 0258fafb9 — switched to `nzWidth: "max(900px, 60vw)"`. The 900px
floor preserves the layout fix while `60vw` scales the modal on wider viewports.
Worth flagging: the original `"900px"` was actually picked to match the
existing convention — every other `nzWidth` in the frontend codebase is a
static px string (e.g. `"700px"`/`"800px"`/`"900px"` in `menu.component.ts:668`
and three other call sites in this same file). After this change, this is the
only modal using a dynamic width expression. Might be worth a follow-up
refactor to standardize all modals on `max(<floor>, <vw>)` so the whole
frontend scales uniformly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
