Yicong-Huang commented on code in PR #5151:
URL: https://github.com/apache/texera/pull/5151#discussion_r3290014515
##########
amber/src/test/scala/org/apache/texera/amber/engine/faulttolerance/CheckpointSpec.scala:
##########
@@ -73,16 +73,20 @@ class CheckpointSpec extends AnyFlatSpecLike with
BeforeAndAfterAll {
)
val chkpt = new CheckpointState()
chkpt.save(CP_STATE_KEY, cp)
+ val restored: ControllerProcessor = chkpt.load(CP_STATE_KEY)
+ assert(restored.actorId == cp.actorId)
}
- "Default worker state" should "be serializable" in {
+ "Default worker state" should "round-trip through CheckpointState" in {
val dp = new DataProcessor(
SELF,
msg => {},
inputMessageQueue = new LinkedBlockingQueue[DPInputQueueElement]()
)
val chkpt = new CheckpointState()
chkpt.save(DP_STATE_KEY, dp)
+ val restored: DataProcessor = chkpt.load(DP_STATE_KEY)
+ assert(restored.actorId == dp.actorId)
Review Comment:
are these changes even related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
