Ma77Ball commented on code in PR #5151:
URL: https://github.com/apache/texera/pull/5151#discussion_r3293541917
##########
frontend/src/app/dashboard/component/dashboard.component.spec.ts:
##########
@@ -162,4 +177,48 @@ describe("DashboardComponent", () => {
expect(fixture.debugElement.query(By.css("#powered-by"))).toBeTruthy();
});
+
+ it("should hide the navbar on workflow workspace routes", () => {
+ expect(component.isNavbarEnabled("/user/workflow/42")).toBe(false);
+ expect(component.isNavbarEnabled("/user/workflow")).toBe(true);
+ expect(component.isNavbarEnabled("/user/project")).toBe(true);
+ });
+
+ it("exposes route constants without the legacy /dashboard prefix", () => {
+ expect(USER_PROJECT).toBe("/user/project");
Review Comment:
ditto this can be a separate issue I can raise if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
