Ma77Ball commented on code in PR #5153:
URL: https://github.com/apache/texera/pull/5153#discussion_r3292535615
##########
frontend/build-version.js:
##########
@@ -17,17 +17,12 @@
* under the License.
*/
-const { gitDescribeSync } = require("git-describe");
+const { generate } = require("build-number-generator");
const { version } = require("./package.json");
const { resolve, relative } = require("path");
const { writeFileSync, existsSync, mkdirSync } = require("fs-extra");
-const gitInfo = gitDescribeSync({
- dirtyMark: false,
- dirtySemver: false,
-});
-
-gitInfo.version = version;
+const buildNumber = generate(version);
Review Comment:
Yes, this was a design decision because the buildNumber includes the date.
- In the current format, it shows the date when `yarn install` is run.
- In the advised format, it shows the date the user loads the page.
Overall, I've opted to remove the date and support your suggestion to
eliminate the need for the post-install script.
##########
frontend/build-version.js:
##########
@@ -17,17 +17,12 @@
* under the License.
*/
-const { gitDescribeSync } = require("git-describe");
+const { generate } = require("build-number-generator");
const { version } = require("./package.json");
const { resolve, relative } = require("path");
const { writeFileSync, existsSync, mkdirSync } = require("fs-extra");
-const gitInfo = gitDescribeSync({
- dirtyMark: false,
- dirtySemver: false,
-});
-
-gitInfo.version = version;
+const buildNumber = generate(version);
Review Comment:
Yes, this was a design decision because the buildNumber includes the date.
- In the current format, it shows the date when `yarn install` is run.
- In the advised format, it shows the date the user loads the page.
Overall, I've opted to remove the date and support your suggestion to
eliminate the need for the post-install script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
