Yicong-Huang commented on code in PR #5153:
URL: https://github.com/apache/texera/pull/5153#discussion_r3293589461
##########
frontend/build-version.js:
##########
@@ -17,17 +17,12 @@
* under the License.
*/
-const { gitDescribeSync } = require("git-describe");
+const { generate } = require("build-number-generator");
const { version } = require("./package.json");
const { resolve, relative } = require("path");
const { writeFileSync, existsSync, mkdirSync } = require("fs-extra");
-const gitInfo = gitDescribeSync({
- dirtyMark: false,
- dirtySemver: false,
-});
-
-gitInfo.version = version;
+const buildNumber = generate(version);
Review Comment:
hmm. neither option is reflecting the actual build time.
- `yarn install` is to install packages. we need to generate this date when
we actually build frontend for prod.
- "when user loads the page" is also meaning less to be shown as a build
time.
can we bundle this command with `yarn run build --prod` etc (I might be
wrong on the exact build command)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
