Yicong-Huang opened a new issue, #5192:
URL: https://github.com/apache/texera/issues/5192

   ### Task Summary
   
   `code-editor.component.ts` reaches ~49% line coverage under jsdom after 
#5191 — the rest is inside paths that need a real Monaco editor (the 
`editorWrapper.initAndStart` subscribe body, `initializeDiffEditor`, 
`setupAIAssistantActions` registered actions, `handleTypeAnnotation`'s 
`getScrolledVisiblePosition`). All of these run only when Monaco actually 
instantiates against a real canvas.
   
   A sibling browser spec (`code-editor.component.browser.spec.ts`) routed 
through the existing `gui:test-browser` (Playwright + Chromium) target is the 
right home for those tests. The first cut hit a polyfill chain that needs more 
setup than a single test addition can carry — `monaco-editor-wrapper` and 
`monaco-vscode-files-service-override` dereference Node's `Buffer` (including 
`Buffer.allocUnsafe`) at module evaluation, and `buffer` itself is a CommonJS 
module that Vite's browser bundler cannot run. A sentinel polyfill is enough 
for the first gate but not for `allocUnsafe`. Resolving this needs either 
`vite-plugin-node-polyfills` or an inline Buffer polyfill substantial enough to 
keep monaco's internals happy.
   
   Stand up the browser-mode plumbing, then write tests that exercise the 
editor-init, diff-editor, AI-action-registration, and resize paths.
   
   ### Task Type
   
   - [x] Testing / QA
   - [x] DevOps / Deployment / CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to