Yicong-Huang commented on code in PR #5201: URL: https://github.com/apache/texera/pull/5201#discussion_r3300161974
########## amber/src/main/scala/org/apache/texera/web/auth/JwtAuth.scala: ########## @@ -25,8 +25,8 @@ import io.dropwizard.setup.Environment import org.apache.texera.auth.JwtAuth.jwtConsumer import org.apache.texera.auth.SessionUser -// TODO: move this logic to Auth -@Deprecated +// TODO: move this logic to common/auth once it depends on Dropwizard, so amber +// services can drop the toastshaman dropwizard-auth-jwt filter. Review Comment: deprecation is kind of standard process though. for instance if someone forks our repo and developers himself, he will receive this information from code (not from our issue). I agree warnings are annoying, but let's resolve the warning (by actually clean up this JwtAuth), instead of getting rid of it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
