kunwp1 commented on code in PR #5201:
URL: https://github.com/apache/texera/pull/5201#discussion_r3300194106


##########
file-service/src/main/scala/org/apache/texera/service/type/serde/DatasetFileNodeSerializer.java:
##########
@@ -53,7 +53,7 @@ public void serialize(DatasetFileNode value, JsonGenerator 
gen, SerializerProvid
             gen.writeFieldName("children");
             gen.writeStartArray();
             List<DatasetFileNode> children = value.getChildren();
-            for (DatasetFileNode child : 
JavaConverters.seqAsJavaList(children)) {
+            for (DatasetFileNode child : 
CollectionConverters.asJava(children)) {

Review Comment:
   I introduced a new flag to the build.sbt. For this type of error it will 
give the following message:
   
   ```
   [warn] 
/Users/kunwoopark/workspace/fork/texera-worktrees/chore-fix-sbt-warnings/file-service/src/main/scala/org/apache/texera/service/type/serde/DatasetFileNodeSerializer.java:56:56:
 <A>seqAsJavaList(scala.collection.Seq<A>) in scala.collection.JavaConverters 
has been deprecated
   [warn] JavaConverters.seqAsJavaList
   [warn]                             ^
   [error] 
/Users/kunwoopark/workspace/fork/texera-worktrees/chore-fix-sbt-warnings/file-service/src/main/scala/org/apache/texera/service/type/serde/DatasetFileNodeSerializer.java:
 warnings found and -Werror specified
   [error] (FileService / Compile / compileIncremental) javac returned non-zero 
exit code
   [error] Total time: 2 s, completed May 25, 2026, 3:40:00 PM
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to