Xiao-zhen-Liu commented on code in PR #5146:
URL: https://github.com/apache/texera/pull/5146#discussion_r3320350410
##########
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts:
##########
@@ -844,52 +853,56 @@ describe("WorkflowEditorComponent", () => {
// }
// });
- it("should highlight multiple operators when user clicks on them with
shift key pressed", () => {
- const jointGraphWrapper = workflowActionService.getJointGraphWrapper();
-
- workflowActionService.addOperator(mockScanPredicate, mockPoint);
- workflowActionService.addOperator(mockResultPredicate, mockPoint);
- jointGraphWrapper.highlightOperators(mockResultPredicate.operatorID);
-
- // assert that only the last operator is highlighted
-
expect(jointGraphWrapper.getCurrentHighlightedOperatorIDs()).toContain(mockResultPredicate.operatorID);
-
expect(jointGraphWrapper.getCurrentHighlightedOperatorIDs()).not.toContain(mockScanPredicate.operatorID);
-
- // find the joint Cell View object of the first operator element
- const jointCellView =
component.paper.findViewByModel(mockScanPredicate.operatorID);
-
- // trigger a shift click on the cell view using its jQuery element
- const event = createJQueryEvent("mousedown", { shiftKey: true });
- jointCellView.$el.trigger(event);
-
- fixture.detectChanges();
-
- // assert that both operators are highlighted
-
expect(jointGraphWrapper.getCurrentHighlightedOperatorIDs()).toContain(mockScanPredicate.operatorID);
-
expect(jointGraphWrapper.getCurrentHighlightedOperatorIDs()).toContain(mockResultPredicate.operatorID);
- });
-
- it("should unhighlight the highlighted operator when user clicks on it
with shift key pressed", () => {
- const jointGraphWrapper = workflowActionService.getJointGraphWrapper();
-
- workflowActionService.addOperator(mockScanPredicate, mockPoint);
- jointGraphWrapper.highlightOperators(mockScanPredicate.operatorID);
-
- // assert that the operator is highlighted
-
expect(jointGraphWrapper.getCurrentHighlightedOperatorIDs()).toContain(mockScanPredicate.operatorID);
-
- // find the joint Cell View object of the operator element
- const jointCellView =
component.paper.findViewByModel(mockScanPredicate.operatorID);
-
- // trigger a shift click on the cell view using its jQuery element
- const event = createJQueryEvent("mousedown", { shiftKey: true });
- jointCellView.$el.trigger(event);
-
- fixture.detectChanges();
-
- // assert that the operator is unhighlighted
-
expect(jointGraphWrapper.getCurrentHighlightedOperatorIDs()).not.toContain(mockScanPredicate.operatorID);
- });
+ // TODO(#3614): the next two shift-click multi-select tests also depend on
Review Comment:
Same concern as the earlier commented-out block — these shift-click tests
are also removed from every target, including `test-browser`. `it.skip`/`xit`
or an env-guard would keep them visible and reviveable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
